Leaderboard app with query #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inator/leaderboard-app-with-query # Conflicts: # packages/web/env-config.js.template # packages/web/src/dev/Engage.tsx # packages/web/src/dev/LeaderBoard.tsx # packages/web/src/dev/LeaderBoardApp.tsx # packages/web/static/locales/en/dev.json
aaronmgdr
reviewed
Nov 26, 2019
| @@ -97,10 +94,11 @@ function sorter(alpha: Competitor, bravo: Competitor) { | |||
| return -1 | |||
| } | |||
|
|
|||
| const PORTIONS = 8 | |||
| const Portions = 8 | |||
There was a problem hiding this comment.
why the change? for consts all caps is really more common, with Pascalcase I tend to think interfaces or classes
There was a problem hiding this comment.
true, the linter was complaining, but we can revert
aaronmgdr
reviewed
Nov 26, 2019
| @@ -9,7 +9,7 @@ const environments = { | |||
| projectId: 'celo-faucet', | |||
| }, | |||
| LEADERBOARD: { | |||
| uri: "http://localhost:8080/v1/graphql", | |||
| uri: "http://localhost:4000/graphiql", | |||
There was a problem hiding this comment.
I assume eventually this will be a non localhost URL?
There was a problem hiding this comment.
yes, it should be the one of blockscout
aaronmgdr
approved these changes
Nov 26, 2019
|
Seems circleci is having some issues. probably |
cmcewen
pushed a commit
that referenced
this pull request
Nov 27, 2019
* new stack area before too much crazy * Freeze the illustration as we scroll past it * Mobile and tablet sizes working * fix hash link scroll to correct offset * Add leaderboard * Add browse code button to full stack area and update title of features area * Order those imports * Add connection footer to build page * More copying of files from other branch over * Add alignment options to social channels * JK * Add back translations * add Transcieve graphic * mathemagic * Reduce lines and cleanup code * Wait 2 seconds before running animation * The great celo stake off * That sweet baking * Set max height for graphic * Three mode stickiness * Engagement area of build page with mobile support * Fix Buttons on Firebox being wrong sized * Add space between buttons * When scrolling up our little illogical re attaches to the flow * This works. Maybe I can make better * Highlight ALL layers when code * Little fixes * Build updates * Updates to engage * Merging Diminator leaderboard into aaronmgdr /build (#1860) * - make page / baklava - leaderboard app with graphql fetch * fix lint * port leaderboard app to dev page * remove unused packages * expand leaderboard and env vars * Let the games begin * Lint fix * Leaderboard app with query (#1864) * cherry pick leaderboard app * web site changes * it was changed now * cleanup * fix duplicate import * Fuck yeah * Some improvements * lockfile changes * Add terms link * Always be linting * Fix lint errors * Lint * Show leaderboard and handle empty array * Fix env config * Prettify template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR requires branch
aaronmgdr/build4Implements the dynamic leaderboard app using a graphql query and leaderboard script:
#1810
Tested
Tested by running locally.
Related issues
To check
I'm not sure how
env-config.js.templateworks