[Wallet] Fix iOS bundle script failing with our monorepo setup #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solutions found in react-native-community/cli#656 didn't help but setting PROJECT_ROOT in the build phase script worked.
jmrossy
approved these changes
Nov 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
========================================
Coverage 74.17% 74.17%
========================================
Files 278 278
Lines 7687 7687
Branches 965 677 -288
========================================
Hits 5702 5702
Misses 1869 1869
Partials 116 116
Continue to review full report at Codecov.
|
celo-ci-bot-user
deleted the
jeanregisser/fix-ios-bundle-script-phase-failure
branch
aaronmgdr
added a commit
that referenced
this pull request
Dec 4, 2019
* master: (120 commits) Update docker image and instructions (#2000) DOCS correct typos (#1965) Add a space on payment request (#1935) expose signer through getValidator (#1997) Fix validator election migration bug with sorted list insertion (#1998) Deploy an oracle cronjob (#1814) Set default env in attestation service docker image as production (#1999) Attestation Bot POC (#1851) Only allow external RPCs for tx nodes (#1994) Specify web deps properly (#1950) Fix error calculating fees on currencies with high exchange rate (#1937) Small pre-stake-off CLI cleanup (#1953) Migrations: different CLabs groups gets different votes (#1960) [Wallet] Fix broken translation (decline, pay) (#1968) [Wallet]: Add Payments You've Requested notifications group & screen (#1902) [Wallet] Fix iOS bundle script failing with our monorepo setup (#1958) [NotificationService] Change exchange rate stored format (number timestamp and pair) (#1945) [Wallet] Fix premature hiding of syncing banner and increase some timeouts (#1957) Avoid `liner: function not supported in this terminal` (#1955) Support more human readable log output (#1929) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Archive builds were failing during the bundle build phase script on iOS. The upgrade to RN 0.61 broke this.
The solutions found in react-native-community/cli#656 didn't help
but setting PROJECT_ROOT in the build phase script worked.
Tested
Archive builds work on iOS.
Backwards compatibility
Yes.