Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting more Validator UX improvements #2017

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Collecting more Validator UX improvements #2017

merged 5 commits into from
Dec 4, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Dec 3, 2019

Description

Adding some more documentation & command improvements to prepare for the baklava stake off

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Other changes

Describe any minor or "drive-by" changes here.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@asaj asaj requested a review from mcortesi as a code owner December 4, 2019 00:02
Copy link
Contributor Author

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmoreton can you confirm that the scripts are working?

packages/docs/getting-started/running-a-validator.md Outdated Show resolved Hide resolved
packages/docs/getting-started/running-a-validator.md Outdated Show resolved Hide resolved
export CELO_VALIDATOR_SIGNER_ADDRESS=<YOUR-VALIDATOR-SIGNER-ADDRESS>
docker run --name celo-proxy --restart always -p 30313:30303 -p 30313:30303/udp -p 30503:30503 -p 30503:30503/udp -v $PWD:/root/.celo $CELO_IMAGE --verbosity 3 --networkid $NETWORK_ID --syncmode full --proxy.proxy --proxy.proxiedvalidatoraddress $CELO_VALIDATOR_SIGNER_ADDRESS --proxy.internalendpoint :30503
docker run --name celo-proxy --restart always -p 30313:30303 -p 30313:30303/udp -p 30503:30503 -p 30503:30503/udp -v $PWD:/root/.celo $CELO_IMAGE --verbosity 3 --networkid $NETWORK_ID --syncmode full --proxy.proxy --proxy.proxiedvalidatoraddress $CELO_VALIDATOR_SIGNER_ADDRESS --proxy.internalendpoint :30503 --etherbase $CELO_VALIDATOR_SIGNER_ADDRESS --ethstats=<YOUR-VALIDATOR-NAME>-proxy@baklava-ethstats.celo-testnet.org
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in @aaitor 's original PR, but is there any reason to set the etherbase here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure! Dimi said "if you want, feel free to try
--ethstats=VALIDATOR_NAME@baklava-ethstats.celo-testnet.org
for both proxy and validator
(Might be that the proxy wants an --etherbase so you'd need to make a key for the proxy)"

packages/docs/getting-started/running-a-validator.md Outdated Show resolved Hide resolved
@timmoreton timmoreton merged commit 09f64fc into master Dec 4, 2019
@mcortesi mcortesi deleted the asaj/docs branch December 4, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants