Rename to eventName #2021
Merged
Rename to eventName #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
=======================================
Coverage 74.45% 74.45%
=======================================
Files 281 281
Lines 7817 7817
Branches 973 973
=======================================
Hits 5820 5820
Misses 1880 1880
Partials 117 117
Continue to review full report at Codecov.
|
tkporter
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use
eventin our structured logs to denote the type of event we are emitting, however ethereum logs also have a property calledeventfor the name of the log. Here we are renaming it toeventNameso that we avoid the collision.