Make validator-exec work for different node types #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoreton
approved these changes
Dec 10, 2019
| const instanceNames = [] | ||
| if (argv.only === null) { | ||
| const nodeCount = getNodeCount(argv.nodeType) | ||
| console.log(`Node Count: ${nodeCount}`) |
There was a problem hiding this comment.
lint doesn't like console.log
| instanceNames.push(instanceName) | ||
| } | ||
| } else { | ||
| console.log(`Only Index: ${argv.only}`) |
Codecov Report
@@ Coverage Diff @@
## master #2145 +/- ##
========================================
Coverage 74.77% 74.77%
========================================
Files 280 280
Lines 7826 7826
Branches 690 974 +284
========================================
Hits 5852 5852
Misses 1858 1858
Partials 116 116
Continue to review full report at Codecov.
|
added 5 commits
December 10, 2019 22:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the name of the celotool cmd
validator-exectovm-exec, and extends the command to work on any node type (bootnode/tx-node/validator/proxy)Tested
Ran some cmds on every node in baklavastaging
Other changes
n/a
Related issues
n/a
Backwards compatibility
Apart from the old command not existing anymore, yes