-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opengraph metadata #2238
Add opengraph metadata #2238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have these metadata tags on every page? If so, should they be added to the Page component?
Codecov Report
@@ Coverage Diff @@
## master #2238 +/- ##
=========================================
Coverage ? 74.81%
=========================================
Files ? 276
Lines ? 7766
Branches ? 976
=========================================
Hits ? 5810
Misses ? 1839
Partials ? 117
Continue to review full report at Codecov.
|
@jmrossy Im not clear on what you are asking/proposing. We do want each page in the brandkit and most other pages to have the metatags. They are mostly different per page, the brandkit pages do share a preview image however. note the component is only for brandkit experience pages. |
@aaronmgdr My thought was to have these be mandatory props of for each Page wrapper if we wanted them on every page. If we don't then nevermind :) |
Assigning back as tests are failing |
Description
Add full Open Graph meta data to brand Kit pages
add open graph image to
/build/faucet
/build/wallet
Tested
confirmed the title and description, should test image shows correct once not on localhost
Other changes
Describe any minor or "drive-by" changes here.
Related issues