Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload bootnode info & use in docs instead of static nodes #2289

Merged
merged 8 commits into from
Dec 18, 2019

Conversation

tkporter
Copy link
Contributor

Description

This uploads a file to GCS containing the enode URL of the bootnode upon deploying a network, and has users use the bootnode to discover other nodes in the docs for the proxy and attestation service nodes.

Seeing as the node run locally is temporary, I kept that using static nodes. This avoids polluting the bootnode discovery table & also ensures quick peer connections. I'm open to changing this though

Tested

Ran it myself and was able to find nodes through the bootnode

Other changes

Cleaned up a little code and fixed a couple small nits in the docs

Related issues

Partner PR in blockchain: celo-org/celo-blockchain#769

Backwards compatibility

Requires a new version of celo-node resulting from this PR: celo-org/celo-blockchain#769

@tkporter tkporter added the automerge Have PR merge automatically when checks pass label Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #2289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2289   +/-   ##
=======================================
  Coverage   74.89%   74.89%           
=======================================
  Files         274      274           
  Lines        7803     7803           
  Branches      701      701           
=======================================
  Hits         5844     5844           
  Misses       1846     1846           
  Partials      113      113
Flag Coverage Δ
#mobile 74.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e599ef8...408b3b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants