Improve attestation service init error message when the node is not synced #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the node is still syncing, `web3.eth.isSyncing()` will return `false`. Telling the operator that the node is "not syncing" is misleading, so let's use a more accurate error message.
szym
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
========================================
Coverage 74.55% 74.55%
========================================
Files 278 278
Lines 7777 7777
Branches 707 991 +284
========================================
Hits 5798 5798
Misses 1868 1868
Partials 111 111
Continue to review full report at Codecov.
|
|
Obsoleted by #2372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error received while the node sync was under way but not yet complete:
When the node is still syncing,
web3.eth.isSyncing()will returnfalse. In that case, telling the operator that the node is "not syncing" is misleading, so let's use a more accurate error message.Tested
Error message string. Tested manually.
Other changes
None.
Related issues
None.
Backwards compatibility
Fully backwards compatible, unless some tool is actually parsing the error message.