Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rewards page from web #2353

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

aaronmgdr
Copy link
Member

Description

Remove hacked together rewards page

Tested

Other changes

Related issues

Backwards compatibility

technically a very very very old version of wallet used this.

Remove hacked together rewards page
@aaronmgdr aaronmgdr added the web label Jan 2, 2020
@aaronmgdr aaronmgdr changed the title Fixes https://github.com/celo-org/celo-labs/issues/205 Remove Rewards page from web Jan 2, 2020
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #2353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2353   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         278      278           
  Lines        7777     7777           
  Branches      707      707           
=======================================
  Hits         5798     5798           
  Misses       1868     1868           
  Partials      111      111
Flag Coverage Δ
#mobile 74.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d75d6...037782c. Read the comment docs.

@cmcewen cmcewen added the automerge Have PR merge automatically when checks pass label Jan 2, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 16e2790 into master Jan 2, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the aaronmgdr/remove-rewards branch January 2, 2020 21:54
aaronmgdr added a commit that referenced this pull request Jan 3, 2020
* master:
  Adding a command to the docker script allowing to stop validating (#2295)
  Update prettier to 1.19.1 to support TypeScript 3.7 (optional chaining, nullish coalescing, etc) (#2358)
  Fixes needed to make slashing work (#2346)
  Remove Rewards page from web (#2353)
  Remove rep sentence from brand kit page (#2350)

# Conflicts:
#	packages/web/src/header/Header.3.tsx
#	yarn.lock
aaronmgdr added a commit that referenced this pull request Jan 4, 2020
* master:
  Adding a command to the docker script allowing to stop validating (#2295)
  Update prettier to 1.19.1 to support TypeScript 3.7 (optional chaining, nullish coalescing, etc) (#2358)
  Fixes needed to make slashing work (#2346)
  Remove Rewards page from web (#2353)
lucasege pushed a commit that referenced this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants