Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N21] Inconsistent use of onlyVm modifier #2903

Merged
merged 5 commits into from
Feb 25, 2020
Merged

[N21] Inconsistent use of onlyVm modifier #2903

merged 5 commits into from
Feb 25, 2020

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Feb 23, 2020

Description

Share this code via inheriting CalledByVm.sol

Tested

No

Other changes

No

Related issues

Backwards compatibility

Yes

Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GasPriceMinimum.sol, GoldToken.sol and StableToken.sol still have their own onlyVm modifiers.

@mrsmkl mrsmkl assigned asaj and unassigned mrsmkl Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2903 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2903   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files         570      570           
  Lines       14273    14273           
  Branches     1721     1721           
=======================================
  Hits        10475    10475           
  Misses       3513     3513           
  Partials      285      285
Flag Coverage Δ
#mobile 73.77% <0%> (ø) ⬆️
#web 72.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed15eb...4e65a13. Read the comment docs.

@asaj asaj assigned nambrot and unassigned asaj Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants