-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N22] Not using EIP 1967: Standard Proxy Storage Slots #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2904 +/- ##
========================================
Coverage 73.37% 73.37%
========================================
Files 570 570
Lines 14277 14277
Branches 1722 1418 -304
========================================
Hits 10476 10476
Misses 3516 3516
Partials 285 285
Continue to review full report at Codecov.
|
mrsmkl
approved these changes
Feb 24, 2020
lucasege
pushed a commit
that referenced
this pull request
Feb 26, 2020
This was referenced Dec 6, 2021
This was referenced Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change proxy storage slots to comply with EIP 1967 (draft).
Tested
No
Other changes
No
Related issues
Backwards compatibility
No