Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N22] Not using EIP 1967: Standard Proxy Storage Slots #2904

Merged
merged 31 commits into from
Feb 25, 2020

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Feb 23, 2020

Description

Change proxy storage slots to comply with EIP 1967 (draft).

Tested

No

Other changes

No

Related issues

Backwards compatibility

No

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2904    +/-   ##
========================================
  Coverage   73.37%   73.37%            
========================================
  Files         570      570            
  Lines       14277    14277            
  Branches     1722     1418   -304     
========================================
  Hits        10476    10476            
  Misses       3516     3516            
  Partials      285      285
Flag Coverage Δ
#mobile 73.75% <ø> (ø) ⬆️
#web 72.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be1bcf...5fd04c2. Read the comment docs.

@mrsmkl mrsmkl removed their assignment Feb 24, 2020
@mrsmkl mrsmkl added the automerge Have PR merge automatically when checks pass label Feb 24, 2020
@asaj asaj assigned asaj and unassigned m-chrzan Feb 24, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 269a669 into master Feb 25, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the asaj/eip1967 branch February 25, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit audit-fix automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants