Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix PIN entering screen, when account is not created yet #2932

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Feb 25, 2020

Description

This fixed the following bug:

  1. Choose lang -> enter phone + name -> enter pin two times
  2. Close the app or wait until cached PIN is expired
  3. Paste invite code
  4. PIN screen would hang (this PR fixes this)

Tested

Ran on Android device

Backwards compatibility

Yes

Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 👍

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2932 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
- Coverage   73.37%   73.37%   -0.01%     
==========================================
  Files         570      570              
  Lines       14277    14278       +1     
  Branches     1722     1786      +64     
==========================================
  Hits        10476    10476              
+ Misses       3516     3515       -1     
- Partials      285      287       +2     
Flag Coverage Δ
#mobile 73.74% <0.00%> (-0.01%) ⬇️
#web 72.85% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/web/src/utils/utils.ts 71.69% <0.00%> (ø) ⬆️
packages/web/src/utils/abortableFetch.ts 71.42% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e42eb82...1b5b5ae. Read the comment docs.

@i1skn i1skn merged commit 0cab4b3 into master Feb 25, 2020
@jmrossy jmrossy deleted the i1skn/fix-pin-invite branch February 25, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants