Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips on Validator explorer #4018

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

Pedro-vk
Copy link
Contributor

@Pedro-vk Pedro-vk commented Jun 5, 2020

Description

Add tooltips on Validator explorer

Tested

Tested on Chrome

@@ -25,6 +25,7 @@ export default class Hoverable extends React.Component<Props, State> {
}

checkIfHoverEnabled = () => {
console.log('check')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove before merge

pStaticOverflow: {
position: 'static',
zIndex: 'initial',
overflow: 'initial',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious which of these is causing it to need to be typed as any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "initial" value seems not supported

@Pedro-vk Pedro-vk added the automerge Have PR merge automatically when checks pass label Jun 10, 2020
@Pedro-vk Pedro-vk force-pushed the pedro-vk/feature/validator-explorer-improvements branch from 60bb230 to 5a4628e Compare June 10, 2020 01:18
@mergify mergify bot merged commit 34acb22 into master Jun 10, 2020
@mergify mergify bot deleted the pedro-vk/feature/validator-explorer-improvements branch June 10, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants