Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions #4025

Merged
merged 6 commits into from
Jun 8, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@
"https-proxy-agent": "^5.0.0",
"mixin-deep": "^2.0.1",
"js-yaml": "^3.13.1",
"ganache-core": "https://github.com/celo-org/ganache-core.git#e7bc0bd"
"ganache-core": "https://github.com/celo-org/ganache-core.git#e7bc0bd",
"cryptiles": "^4.1.3",
"hoek": "^6.1.3",
"randomatic": "^3.1.1",
"logkitty": "^0.7.1",
"minimist": "^1.2.5",
"npm": "^6.14.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that this is a dependency somewhere

}
}
2 changes: 1 addition & 1 deletion packages/blockchain-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@celo/contractkit": "0.3.6",
"@celo/utils": "0.1.9",
"apollo-datasource-rest": "^0.8.1",
"apollo-server-express": "^2.12.0",
"apollo-server-express": "^2.14.2",
"bignumber.js": "^9.0.0",
"dotenv": "^8.2.0",
"express": "^4.17.1",
Expand Down
7 changes: 6 additions & 1 deletion packages/contractkit/src/utils/tx-uri.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { trimLeading0x } from '@celo/utils/lib/address'
import BN from 'bn.js'
import { range } from 'lodash'
import qrcode from 'qrcode'
import querystring from 'querystring'
Expand Down Expand Up @@ -99,7 +100,11 @@ export function buildUri(tx: Tx, functionName?: string, abiTypes: string[] = [])
if (functionArgs) {
uri += `args=[${functionArgs.join(',')}]`
}
uri += querystring.stringify({ ...txQueryParams })
const params = txQueryParams as { [key: string]: string }
if (txQueryParams.value instanceof BN) {
params.value = txQueryParams.value.toString()
}
uri += querystring.stringify({ ...params })

return uri
}
Expand Down
6 changes: 3 additions & 3 deletions packages/faucet/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
"build:rules": "firebase-bolt database-rules.bolt"
},
"dependencies": {
"@firebase/app": "^0.5.3",
"@google-cloud/logging": "^7.1.0",
"@celo/contractkit": "0.3.6",
"@celo/utils": "0.1.9",
"@firebase/app": "^0.5.3",
"@google-cloud/logging": "^7.1.0",
"debug": "^4.1.1",
"firebase": "^7.8.0",
"firebase-admin": "^8.10.0",
Expand All @@ -36,7 +36,7 @@
"@types/yargs": "^13.0.2",
"cross-env": "5.2.0",
"firebase-bolt": "^0.8.4",
"firebase-tools": "^8.0.0",
"firebase-tools": "^8.4.2",
"rimraf": "2.6.3",
"yargs": "14.0.0"
},
Expand Down
Loading