-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Restore Account Key screen redesign #4201
Conversation
@coreycelo please take a look on the temporary proposed design changes if that's ok, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional comment but looks good to me.
<View style={styles.loadingSpinnerContainer} testID="ImportWalletLoadingCircle"> | ||
<ActivityIndicator size="large" color={colors.celoGreen} /> | ||
</View> | ||
<HeaderHeightContext.Consumer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will other onboarding screen need these wrappers HeaderHeight and SafeArea wrappers? Wondering if we should just make a single wrapper component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, tbh I've just copied from what @jeanregisser has implemented. I guess we could created a wrapper out of it if need it more. @jeanregisser wdyt?
@i1skn Cool. This is something that will confuse some users so it'd be good to get it in eventually, but makes sense. In the second screenshot after the video, the word "medal" is underlined. Is that an Android text field feature or part of the app? |
It's Android feature. |
Description
Redesigning Account Key screen in onboarding https://www.figma.com/file/zt7aTQ5wuXycIwxq5oAmF9/Wallet--Refresh?node-id=5404%3A440. I've straggled to make multiline input to work as expected on both platform, when
placeholder
is multiline, but no luck. So I've decided to use short placeholder for now and later come back to this problem. This means, that instead of full 24 words as a placeholder you would see only a first couple of them followed by...
(see Screenshots)Tested
Android and iPhone
Related issues
Backwards compatibility
Yes
Screenshots