[Wallet] Add balance and contact tracking #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
reviewed
Jun 25, 2020
| CustomEventNames.fetch_balance, | ||
| token === CURRENCY_ENUM.DOLLAR | ||
| ? { | ||
| dollarBalance: balance, |
There was a problem hiding this comment.
balance is a big number, i think we want a string or number representation?
There was a problem hiding this comment.
Also it might be nice to just have a balance field and then a separate currency field. Makes empty columns less prevalent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new wallet KPIs require a few analytics we weren't already tracking. This PR adds balance and contact imports tracking, which is the final addition to be able to calculate the KPIs listed here.
Note that transaction size analytics will be calculated using eksportisto data
Tested
Not tested, no logic change- just adding analytics
Related issues
Backwards compatibility
Yes