[L14] Solidity compiler version is not pinned and it is not the same for all contracts #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
requested review from
aaronmgdr,
asaj,
cmcewen,
nategraf and
timmoreton
as code owners
yorhodes
force-pushed
the
yorhodes/L14
branch
from
b6450e5
to
d83c5ce
Compare
yorhodes
force-pushed
the
yorhodes/L14
branch
from
d83c5ce
to
adff0a6
Compare
|
Note, this appears to break Certora tests. Can they not handle 0.5.13, or is it just that they expected a different version and need to be explicitly told to expect the new one? |
m-chrzan
approved these changes
Sep 11, 2020
yorhodes
force-pushed
the
yorhodes/L14
branch
from
adff0a6
to
941791e
Compare
ewilz
pushed a commit
that referenced
this pull request
Sep 29, 2020
…for all contracts (#5032) * Pin solc compiler version to 0.5.13 * Bump solc version in certora test
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.