[Wallet] Fix escrow failing randomly with local currency #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was: `Invalid domainURIPrefix scheme. Scheme needs to be https`
jeanregisser
requested review from
cmcewen,
i1skn and
jmrossy
as code owners
jeanregisser
commented
Sep 10, 2020
| @@ -48,5 +48,5 @@ export function convertLocalAmountToDollars( | |||
| // If the user enters `2.99` cUSD, this function has no impact | |||
| // and `2.99` is still displayed in the confirmation screen. | |||
| export function convertDollarsToMaxSupportedPrecision(amount: BigNumber) { | |||
| return new BigNumber(amount.toPrecision(18, BigNumber.ROUND_UP)) | |||
| return new BigNumber(amount.toFixed(18, BigNumber.ROUND_UP)) | |||
There was a problem hiding this comment.
This was all my bad, I misunderstood the behavior of toPrecision when I implemented this.
It doesn't limit the number to X decimals, but to X significant digits.
See https://mikemcl.github.io/bignumber.js/#toP and https://en.wikipedia.org/wiki/Significant_figures#Significant_figures_rules_explained
toFixed does what we want.
gnardini
approved these changes
Sep 10, 2020
jeanregisser
added
automerge
mergify
bot
deleted the
jeanregisser/fix-escrow-failing-with-local-currency
branch
jeanregisser
added a commit
that referenced
this pull request
Sep 10, 2020
### Description This PR fixes sending an invite with an escrowed payment failing randomly when using a local currency. See details in #3000 ### Other changes - Fixed dynamic link generation never returning and leaving the UI in loading state indefinitely (underlying error was `Invalid domainURIPrefix scheme. Scheme needs to be https`) ### Tested Added new test. Invite with escrow works. ### Related issues - Fixes #3000 ### Backwards compatibility Yes
|
Hi @jeanregisser i have tried to repro issue on test flight build v1.1.0 (21) and able to repro issue.
Please let me know if you want to verify anything else. |
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
### Description This PR fixes sending an invite with an escrowed payment failing randomly when using a local currency. See details in celo-org#3000 ### Other changes - Fixed dynamic link generation never returning and leaving the UI in loading state indefinitely (underlying error was `Invalid domainURIPrefix scheme. Scheme needs to be https`) ### Tested Added new test. Invite with escrow works. ### Related issues - Fixes celo-org#3000 ### Backwards compatibility Yes
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes sending an invite with an escrowed payment failing randomly when using a local currency.
See details in #3000
Other changes
Invalid domainURIPrefix scheme. Scheme needs to be https)Tested
Added new test. Invite with escrow works.
Related issues
Backwards compatibility
Yes