Deploy Attestation Service 1.0.5 to cLabs validators on baklava #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslawson
approved these changes
Oct 19, 2020
| ATTESTATION_SERVICE_DOCKER_IMAGE_TAG="attestation-service-dc5e5dfa07231a4ff4664816a95eae606293eae9" | ||
| ATTESTATION_SERVICE_DOCKER_IMAGE_TAG="attestation-service-1-0-5" | ||
|
|
||
| # We only configured 15 nexmo applications. So delivery receipts from the second 15 will always go to the wrong place for now |
There was a problem hiding this comment.
haha ok -- how much is the monthly fee per application. do we gain much from having half use their own application?
Comment on lines
+50
to
+52
| `--set attestation_service.twilio.accountSid="${fetchEnv(envVar.TWILIO_ACCOUNT_SID)}"`, | ||
| `--set attestation_service.twilio.authToken="${fetchEnv(envVar.TWILIO_ACCOUNT_AUTH_TOKEN)}"`, | ||
| `--set attestation_service.twilio.addressSid="${fetchEnv(envVar.TWILIO_ADDRESS_SID)}"`, |
There was a problem hiding this comment.
huh -- how was this set before? just hardcoded?
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other changes
Describe any minor or "drive-by" changes here.
Tested
Deployed
Backwards compatibility
Yes