Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set blockscout k8s deployments to include erlang node name #8476

Merged
merged 8 commits into from
Aug 6, 2021
Merged

Set blockscout k8s deployments to include erlang node name #8476

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37fac96
Set ws port to the same as http for blockscout.
rkachowski Jul 13, 2021
e0f261d
Add default values for sourcify.
rkachowski Jul 19, 2021
b79f1ba
Apply node names to blockscout startup commands.
rkachowski Aug 3, 2021
2889f21
Use default route instead of localhost for node name.
rkachowski Aug 4, 2021
f3959e6
Set full node name in deployments.
rkachowski Aug 5, 2021
bd408b2
Rename nodeName to erlangNodeName.
rkachowski Aug 5, 2021
c465989
Remove duplicate sourcify.
rkachowski Aug 5, 2021
8ce4c1e
Merge branch 'master' into rkachowski/blockscout-erlang-node-name
rkachowski Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/helm-charts/blockscout/templates/blockscout-api.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
- -c
args:
- |
exec mix cmd --app block_scout_web "iex -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix phx.server"
exec mix cmd --app block_scout_web "iex --name {{ .Values.blockscout.api.erlangNodeName}}@0.0.0.0 -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix phx.server"
ports:
- name: http
containerPort: {{ .Values.blockscout.api.port }}
Expand Down
2 changes: 1 addition & 1 deletion packages/helm-charts/blockscout/templates/blockscout-indexer.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
- -c
args:
- |
exec mix cmd --app indexer "iex -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix"
exec mix cmd --app indexer "iex --name {{ .Values.blockscout.indexer.erlangNodeName}}@0.0.0.0 -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix"
ports:
- name: health
containerPort: {{ .Values.blockscout.indexer.port }}
Expand Down
2 changes: 1 addition & 1 deletion packages/helm-charts/blockscout/templates/blockscout-web.deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
- -c
args:
- |
exec mix cmd --app block_scout_web "iex -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix phx.server"
exec mix cmd --app block_scout_web "iex --name {{ .Values.blockscout.web.erlangNodeName}}@0.0.0.0 -e 'IEx.configure(default_prompt: \"\", alive_prompt: \"\")' -S mix phx.server"
ports:
- name: http
containerPort: {{ .Values.blockscout.web.port }}
Expand Down
9 changes: 8 additions & 1 deletion packages/helm-charts/blockscout/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ blockscout:
requests:
memory: 1000Mi
cpu: 2
erlangNodeName: blockscout-indexer
api:
port: 4000
strategy:
Expand Down Expand Up @@ -98,6 +99,7 @@ blockscout:
requests:
memory: 500Mi
cpu: 500m
erlangNodeName: blockscout-api
web:
port: 4000
strategy:
Expand Down Expand Up @@ -131,6 +133,10 @@ blockscout:
memory: 500Mi
cpu: 700m
pool_size: 10
sourcify:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it overwritten by https://github.com/celo-org/celo-monorepo/pull/8476/files#diff-2d11e60d245b169b75ba864e9455b3204fb19624792b807100e1b8eaa20cc83fR154?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that link is broken, it just redirects to this pull request changes page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's not broken, actually, it's just github's navigation. There is a sourcify section in this file on line 154. I think in yaml, it will take precedence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I guess this is merge damage. I originally needed to add this to get helm to deploy.

enabled: false
serverUrl: ""
repoUrl: ""
readinessProbe:
enabled: true
initialDelaySeconds: 10
Expand All @@ -153,6 +159,7 @@ blockscout:
requests:
memory: 250M
cpu: 500m
erlangNodeName: blockscout-web
image:
repository: gcr.io/celo-testnet/blockscout
tag: v2.0.4-beta-celo
Expand All @@ -165,7 +172,7 @@ blockscout:
name: blockscout
drop: "false"
jsonrpc_http_url: http://tx-nodes-private:8545
jsonrpc_ws_url: ws://tx-nodes-private:8546
jsonrpc_ws_url: ws://tx-nodes-private:8545
metadata_crawler:
schedule: "*/30 * * * *"
image:
Expand Down