Merge master into audit/core-contracts.v5 #8478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added env-tests to github actions * removed environmeent * initial commit * support for staging network * run all tests for staging Co-authored-by: Kevin Jue <kevjue@Kevins-MacBook-Pro.local>
### Description Surface inflation rate and factor in network:parameters ### Tested `celocli network:parameters --node https://forno.celo.org` <img width="435" alt="Screen Shot 2021-07-09 at 2 49 09 PM" src="https://user-images.githubusercontent.com/3020995/125123949-5ab62e00-e0c5-11eb-9896-3af9d1619ff9.png">
…to 8545 (#8161) * Added wsport as configurable. Setting testnet archive wsport default to 8545 * Added FULL_NODES_WS_PORT values * Blockscout using new websocket endpoint at 8545
### Description add section for deploying ETH contract to Celo
* add protocol differences * update to relative links
* changelog added * versions updated * keystore added * chore: resolve to 1.2.3-dev Co-authored-by: Alex Harley <alexbruceharley@gmail.com>
### Description This PR updates the the instructions for running a local devchain by referring to the `celo-devchain` package which includes a pre-generated devchain and avoids the need to clone the monorepo and run the migrations. ### Related issues - Fixes #6758
* some fixes * simple test is working * testing this * still deciding where the checks should be, need cleanup * cleaned this up * lint * review comments * lint
* Added prestop hook to fullnode template. Increased baklava memory * Included new exclusions for prometheus remotewrite and stackdriver for the more frequent unused metrics * Refined exclusion * Update prometheus config * Added encrypted grafana cloud credentials
Co-authored-by: Enrique Ruiz <enrique@keyko.io>
### Description To enable metrics we had a small bug that get fixed with this PR. ### Tested Tested in Alfajores
### Description Fix suggested in [failed CI run](https://app.circleci.com/pipelines/github/celo-org/celo-monorepo/36349/workflows/b03c71a3-61d1-49aa-9d42-fbfbdc3b872d/jobs/476169/parallel-runs/3/steps/3-108) and [slack](https://celo-org.slack.com/archives/CQT5JB2BY/p1626294405043600) ### Tested CI
### Description Adds support for Granda Mento on contractkit. ### Other changes - ### Tested Added tests and modified migrations ### Related issues - Fixes #7773 ### Backwards compatibility None ### Documentation -
* bumps pkg versions * use new input validation logic * fix database error metric (drive-by) * remove timestamp from signer db logic * sdk changes for using deterministic seed and removing timestamp * remove timestamp check from combiner * removes timestamp from combiner getBlindedSig tests * removes timestamp from signer tests * updates lockfile * minor test improvement * updates lockfile * fixes error * bumps contractkit versions in signer and combiner
* Added cEURO to quotes for account validation * Updated ContractKit in phone-number-privacy package * Updated Identity dependency in Combiner * Updated code with PR comments * Added missing yarn.lock * Updated logged message in Quote service * Update yarn.lock * Update signer dependency * Update dependencies in combiner Co-authored-by: Alec Schaefer <alec@cLabs.co>
### Description Deployment automation for creation, updating, deleting of Celo Rewards Service. ### Other changes Remove the private key (mnemonic) method for relayer deployment. This was causing deployment issues and we weren't using it. ### Tested Verified in Alfajores. ### Related issues - Fixes #7835 ### Backwards compatibility Addition of a new micro-service. Does not interfere with existing Komenci services. ### Documentation N/A
various minor fixes and cleanup noticed during ODIS v1.1.8 deployment and e2e testing
* Add missed variable to enable metrics * Use the variable
### Description Fix testnet package if wsPort is 8545 (services cannot have same port defined multiple times)
### Description Small refactor to prometheus remote_write due to old approach (using helm `toYaml` funcion) added single quotes to some fields that should not be included in the template. Also included the encoded variables for grafana cloud in rc1 environment. ### Tested Deployed to rc1 mainnet cluster.
### Description Fixes contract release process scripts and docs to use simplified tagging scheme ### Tested CI ### Backwards compatibility Yes ### Documentation Smart contract release process docs
### Description Following up on #8086, we realized that using mycelo for the tests by default introduces friction for developers making changes to the core contracts, since it requires them to also update the migrations which mycelo uses, which are in the celo-blockchain repo and in Go rather than javascript. So as a compromise, this PR modifies the tests back to not use mycelo by default. Instead, they can be switched by devs to use mycelo temporarily (for local runs) as desired, or forced to use mycelo by setting an env variable: ``` export E2E_TESTS_FORCE_USE_MYCELO=true ``` We expect that for the celo-blockchain CI we will set this environment variable, but we won't for the monorepo CI. ### Tested Verified that the tests now don't use mycelo, but do if you specify the env variable to be true.
### Description - Adds version logic to ContractKit base wrapper to support generic version gatekeeping ### Other changes - Modularize and simplify protocol build scripts to only generate artifacts when necessary - Modify contractkit build:gen script to support targeting contract releases ### Tested - Tests added for base wrapper version compatibility ### Related issues - Fixes #8018 ### Backwards compatibility Yes ### Documentation None
### Description
The Twilio Verify Service is a managed service for sending N-digit codes globally. Because there's no risk of sending marketing material, Twilio can automatically manage regulations for each recipient geography on behalf of the sender. The service also manages localization for select markets. We chose Twilio as the first SMS provider to measure the impact of switching to a Verify Service since it 1) is heavily used by many operators 2) supports sending custom codes which minimizes Valora-side changes.
Changes to note:
- Changes SMS text content
- Android
- from `<#> Celo security code is: 12345678 bU9E4ctGtIW`
- to `<#>Your Celo verification code is: 12345678 bU9E4ctGtIW`
- iOS
- from `Celo security code is: 12345678`
- to `Your Celo verification code is: 12345678`
- Expands localized markets from 3 to 36
- Doesn't support a call-back URL which will affect some metrics on our dashboard
- Supporting verification for landlines (using voice)
Pre-requisite steps for Attestation Service operators:
- Create a new Verify Service in the portal
- Create a support ticket to enable custom security codes
### Other changes
We now include `language` and `appSignature` in the `AttestationModel` object. The Verify API uses these directly to adjust the messaging. Added a new migration file for adding these columns to the Attestations table.
Added `twilioVerifySidProvided` to the /status endpoint and tracking via metadata-crawler.
### Tested
Tested manually in Alfajores using Valora Alfajores app:
- Android device receives app hash and can auto-read message
- Can re-request SMS from same services
- Successfully retrieves signature from AS using security code
### Related issues
- Fixes #8145
### Backwards compatibility
`AttestationModel` objects that are previously stored in the DB do not have the new properties (`language` and `appSignature). When reading the `AttestationModel`, these new properties are be added for compatibility.
### Documentation
Updated Twilio guide
### Description Setup RPC_APIs configuration parameter in testnet templates.
Blockscout staging env config
…t libraries (#8349) ### Description Current Behavior: Multiple contract libraries have versioning bytecode that is overwritten by inheriting contracts or simply unused New Behavior: Removed unnecessary versioning in library contracts. Only difference in functionality would be if one were attempt to query the version of a library with getVersionNumber(), although this is seldom done in practice ### Testing Changes do not need to be tested specifically, since getVersion was not called on libraries. ### Related issues - Consistently unversion contract libraries #7435 ### Backwards compatibility Changes are backwards compatible since the functionality being removed was unnecessary and not used. ### Documentation N/a
### Description CI doesn't automatically look at new directories, so just moving GrandaMento to the stability directory. ### Other changes n/a ### Tested Building & testing ### Related issues n/a ### Backwards compatibility Yes ### Documentation n/a
### Description - changes metadata-crawler image to `77a392216d4927e85ce4b683508fc0539aa92a34` (includes `Verify API changes`) - Note: also changes this value in `helm-charts/blockscout/values.yaml` (hasn't been changed in a while, but should be the same image tag referenced I believe)
### Description I added a few tests to _common_ package of _phone-number-privacy_. Coverage : File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ----------------------|---------|----------|---------|---------|--------------------- All files | 91.67 | 90.63 | 100 | 91.67 | interfaces | 100 | 100 | 100 | 100 | error-utils.ts | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | utils | 88.75 | 89.29 | 100 | 88.75 | authentication.ts | 83.02 | 75 | 100 | 83.02 | 52-55,66-70,128-130 constants.ts | 100 | 100 | 100 | 100 | input-validation.ts | 100 | 100 | 100 | 100 |
yorhodes
requested review from
asaj,
barbaraliau,
cmcewen,
codyborn,
critesjosh,
gastonponti,
mcortesi,
nambrot,
timmoreton and
tkporter
as code owners
* Set ws port to the same as http for blockscout. * Add default values for sourcify. * Apply node names to blockscout startup commands. * Use default route instead of localhost for node name. * Set full node name in deployments. * Rename nodeName to erlangNodeName. * Remove duplicate sourcify.
### Description docs updated to show that Valora maintains Valora (requested by Denisse [here](https://valora-app.slack.com/archives/CL7BVQPHB/p1628185335065300) ) ### Other changes n/a ### Tested previewed the rendered page ### Related issues n/a ### Backwards compatibility n/a ### Documentation This page is updated: https://docs.celo.org/getting-started/wallets
### Description A small change made along with @piersy when forno was having some issues. `--txpool.nolocals` is recommended when exposing nodes publicly: ethereum/go-ethereum#18242 (comment). We noticed it took a really long time for the command to find the most recent block timestamp, which was due to the `transactions.rlp` file being loaded. Adding `--txpool.nolocals` causes that to not be loaded or written to. I added the `--txpool.nolocals` only for GCP-based full nodes, which I believe are only used for forno (@jcortejoso correct me if I'm wrong or if this will mess other infrastructure up that I'm not familiar with). ### Other changes n/a ### Tested Deployed forno full nodes ### Related issues n/a ### Backwards compatibility backward compatible ### Documentation n/a
The timeout was increased to 600 to overcome the time taken to process the txpool local txs, but due to the addition of the -txpool.nolocals flag that extended timeout is no longer required.
### Description Upgrade eksportisto to the latest version which includes this PR: - celo-org/eksportisto#58
Signed-off-by: yorhodes <yorhodes@cLabs.co>
Signed-off-by: yorhodes <yorhodes@cLabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.