Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vulnerable dependency to fixed version #8846

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

codyborn
Copy link
Contributor

Description

Security vulnerability: GHSA-pjwm-rvh2-c87w
Setting dependency to fixed version that does not have vulnerability. 0.7.28 is safe according to this thread.

@aaronmgdr
Copy link
Member

aaronmgdr commented Oct 25, 2021

Id recommended using resolutions so that packages which depend on ua-parser use the version we want.

EDIT: Oops you did do that. Didnt look far enough up

@codyborn codyborn added the automerge Have PR merge automatically when checks pass label Oct 25, 2021
@mergify mergify bot merged commit 10abe03 into master Oct 25, 2021
@mergify mergify bot deleted the cody/SecurityDependencyFix branch October 25, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants