Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cip35 test #8939

Merged
merged 8 commits into from
Dec 2, 2021
Merged

Fix cip35 test #8939

merged 8 commits into from
Dec 2, 2021

Conversation

trianglesphere
Copy link
Contributor

Description

This fixes the test to handle some changes in the 1.10.7 geth merge.

Changes

  • Update one error message
  • Accept that all unprotected (wrt. replay protection) transactions are rejected.
  • Don't send the chainId to geth because it's being incorrectly encodded
  • Change the custom transaction creation logic to match what geth expects (no leading zeros with hex numbers).

Fix cip35 test
ddd51ee 
This fixes the test to handle some changes in the 1.10.7 geth merge.
gastonponti
gastonponti approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trianglesphere trianglesphere added the automerge Have PR merge automatically when checks pass label Dec 2, 2021
@mergify mergify bot merged commit b8cd02c into master Dec 2, 2021
@mergify mergify bot deleted the trianglesphere/fix_cip35_e2e_test branch December 2, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonponti gastonponti gastonponti approved these changes

@asaj asaj Awaiting requested review from asaj

@mcortesi mcortesi Awaiting requested review from mcortesi

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trianglesphere @gastonponti