Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a spread bound check in the setSpread function #9252

Merged
merged 7 commits into from
Feb 1, 2022
Merged

Added a spread bound check in the setSpread function #9252

merged 7 commits into from
Feb 1, 2022

Commits on Jan 27, 2022

  1. added a bound check where spread has to be a valid number between 0 a… 

    …nd 1
    Nina Barbakadze committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    065602d View commit details
    Browse the repository at this point in the history

  2. added a test for the bound check

    Nina Barbakadze committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    b9e0f16 View commit details
    Browse the repository at this point in the history

  3. changed the logical operator helper function from lt to lte

    Nina Barbakadze committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    36a0385 View commit details
    Browse the repository at this point in the history

  4. updated the logical operator so spread is no <= 1

    Nina Barbakadze committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    2475926 View commit details
    Browse the repository at this point in the history

  5. edge case to make sure that transaction reverts if spread is > 1

    Nina Barbakadze committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d0c7ebb View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. removing the unnecessary test-case

    @ninabarbakadze
    ninabarbakadze committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    c945669 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge branch 'master' into ninabarbakadze/spread-bound-check

    @mergify
    mergify[bot] committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    15f6b6d View commit details
    Browse the repository at this point in the history