Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unnecessary calculations with existing constant #9269

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Replace unnecessary calculations with existing constant #9269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
971c9df
replaced unnecessary calculations with SECONDS_IN_A_WEEK constant
Jan 31, 2022
d93f878
Merge branch 'release/core-contracts/7' into ninabarbakadze/unnecessa…
martinvol Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/protocol/test/stability/grandamento.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ contract('GrandaMento', (accounts: string[]) => {
})

describe('#setVetoPeriodSeconds', () => {
const newVetoPeriodSeconds = 60 * 60 * 24 * 7 // 7 days
const newVetoPeriodSeconds = SECONDS_IN_A_WEEK
it('sets the spread', async () => {
await grandaMento.setVetoPeriodSeconds(newVetoPeriodSeconds)
assertEqualBN(await grandaMento.vetoPeriodSeconds(), newVetoPeriodSeconds)
Expand All @@ -1184,7 +1184,7 @@ contract('GrandaMento', (accounts: string[]) => {
})

it('reverts when the veto period is greater than 4 weeks', async () => {
const fourWeeks = 60 * 60 * 24 * 7 * 4
const fourWeeks = SECONDS_IN_A_WEEK * 4
await assertRevertWithReason(
grandaMento.setVetoPeriodSeconds(fourWeeks + 1),
'Veto period cannot exceed 4 weeks'
Expand Down