Update ODIS SDK to accept any type of identifier

[isabellewei]

Description

Creates new functions to interact with ODIS that are not phone number specific

Instead of using the phone number specific identifier and hashing logic that was in the base and utils libraries, I created new functions for the equivalent directly in the odis sdk. I figured that no one would really use that logic outside of the odis sdk anyways (is that a fair assumption?) Eventually I'd like to remove all phone number specific ODIS code

I wanted to use DID methods for the prefixes, but seems like as of now there's only one for twitter, but not email or phone number yet. (As an aside, would be cool if we drafted DID methods for them ourselves!)

Tested

tests updated
backward compatibility test to ensure phone number identifiers are the same

Related issues

• Fixes Update SDK to allow for all types of identifiers #9973

Backwards compatibility

• some functions in phone-number-identifier.ts are kept to maintain backwards compatibility

Documentation

The set of community facing docs that have been added/modified because of this change

[eelanagaraj]

more generally, in addition to the unit tests we should ideally sanity-check this by manually testing that we get the same pepper/identifier for a phone number with the current version of the SDK & updated version from this PR. Reason being is that a breaking change (i.e. we are missing a '+' sign somewhere or added a space, or whatever) would be really hard to spot IMO and would be very difficult to debug!

[alecps]

The two main things I see that need addressing before we can merge this are the same as Eela pointed out.

1. We need a backwards compatibility check somewhere to ensure that we're getting the same identifiers as before. This could maybe be added to the combiner e2e tests
2. It might be better if different prefixes yielded different peppers. If we decide to keep things as they are, we should be sure to document our reasoning.

Though it would be amazing to squeeze this feature into this round of releases, there's a part of me that feels a bit uneasy about rushing this and adding new complexity right at the finish line. Normally this type of feature would be given much more time for careful design / review, and I wonder if it might be best to adjust our expectations to getting this merged after we've released ASv2. I'm not saying we can't get it in beforehand, but we should step back and weigh both options

[isabellewei]

After chatting with @nategraf, agreed that it's best to also append prefixes before blinding the identifiers, but skip this step for phone numbers to maintain backwards compatibility.

I've also added a backwards compatibility test for phone numbers that import an old version of the @celo/identity sdk to compare against the new changes

[alecps]

looking good so far!

[nategraf]

Made a few comments, one with relation to the hashing of identifiers to suggest a two step hash. Overall it looks good.

[alecps]

Nice work!