Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CODEOWNERS #49

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Create CODEOWNERS #49

merged 3 commits into from
Mar 27, 2024

Conversation

lvpeschke
Copy link
Contributor

@lvpeschke lvpeschke commented Feb 26, 2024 •
edited

Add a CODEOWNERS file.
Required step to be able to enforce CODEOWNERS review on the default branches.

@lvpeschke
Create CODEOWNERS
68a8f51 
Add a CODEOWNERS file.
@lvpeschke lvpeschke requested a review from a team February 26, 2024 15:50
arthurgousset
arthurgousset suggested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently getting an error on the CODEOWNER file after my commit:

Unknown owner on line 3: make sure @amitchuapf exists and has write access to the repository
*       @celo-org/devtooling @amitchuapf

Need to fix that before merging the PR.

@lvpeschke
Copy link
Contributor Author

The validation error is likely due to the user not yet having accepted the invitation to the repository.

@arthurgousset arthurgousset self-assigned this Mar 27, 2024
@arthurgousset
Copy link
Contributor

I'll add Alex as codeowner

arthurgousset
arthurgousset approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, now that Alex and Amit have sufficient permissions on this repo.

@arthurgousset arthurgousset merged commit a71360f into main Mar 27, 2024
4 checks passed
@arthurgousset arthurgousset deleted the lvpeschke/CODEOWNERS branch March 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurgousset arthurgousset arthurgousset approved these changes

Assignees

@arthurgousset arthurgousset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lvpeschke @arthurgousset