Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cgp-0063.md #184

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

product-matt
Copy link
Contributor

added description for governance proposal

added description for governance proposal
CGPs/cgp-0063.md Outdated
- WITHDRAWN = The governance proposal is withdrawn before being submitted on the network
### Current Situation
Currently, gas pricing on Celo roughly works as follows:
* Every block a gas_price_minimum is defined (accessible through the GasPriceMinimum smart contract). If the block is full (measured in gas), gas_price_minimum increases, if the block is empty, gas_price_minimum decreases (until gas_price_minimum_(lower_bound) is reached). These increases and decreases can be exponential, and thus the value of gas_price_minimum can change quickly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really full but exceeds the density target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding "denisty target" as word as well - was mostly to describe roughly how it works..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the commit but cannot see the changes above, if there's a better way to respond to comments, let's discuss

511e2e4

CGPs/cgp-0063.md Outdated
Currently, gas pricing on Celo roughly works as follows:
* Every block a gas_price_minimum is defined (accessible through the GasPriceMinimum smart contract). If the block is full (measured in gas), gas_price_minimum increases, if the block is empty, gas_price_minimum decreases (until gas_price_minimum_(lower_bound) is reached). These increases and decreases can be exponential, and thus the value of gas_price_minimum can change quickly.
* In any given block, only transactions specifying a gas_price higher or equal than gas_price_minimum are valid
* The gas paid by users is split between validators (tip) and the community fund (base)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and when the price is at minimum, in reality the majority goes to the community fund.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at minimum, I believe 100% goes to community fund? I've added equations for tip and base which makes this clear.

@product-matt product-matt marked this pull request as draft November 30, 2022 07:02
@product-matt product-matt marked this pull request as ready for review November 30, 2022 07:11
Co-authored-by: Martín Volpe <martin.volpe@gmail.com>
@willkraft willkraft merged commit 9c7e839 into celo-org:martinvol/raise_gas_price Dec 1, 2022
willkraft pushed a commit that referenced this pull request Dec 7, 2022
* WIP

* Update cgp-0063.md (#184)

* Update cgp-0063.md

added description for governance proposal

* Update cgp-0063.md

* Update CGPs/cgp-0063.md

Co-authored-by: Martín Volpe <martin.volpe@gmail.com>

Co-authored-by: Martín Volpe <martin.volpe@gmail.com>

* Update and rename cgp-0063.md to cgp-0066P.md

* Update cgp-0066P.md

changed gas price min data according to @martinvol input

* Rename CGPs/cgp-0063/mainnet.json to CGPs/cgp-0066/mainnet.json

updating folder name

Co-authored-by: Martin Volpe <martin.volpe@gmail.com>
ericnakagawa pushed a commit that referenced this pull request Dec 7, 2022
* WIP

* Update cgp-0063.md (#184)

* Update cgp-0063.md

added description for governance proposal

* Update cgp-0063.md

* Update CGPs/cgp-0063.md

Co-authored-by: Martín Volpe <martin.volpe@gmail.com>

Co-authored-by: Martín Volpe <martin.volpe@gmail.com>

* Update and rename cgp-0063.md to cgp-0066P.md (#186)

* Update and rename cgp-0063.md to cgp-0066P.md

* Update cgp-0066P.md

changed gas price min data according to @martinvol input

* Rename CGPs/cgp-0063/mainnet.json to CGPs/cgp-0066/mainnet.json

updating folder name

Co-authored-by: product-matt <92383609+product-matt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants