Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'main' into gd-gas-proposal #284

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Conversation

sirpy
Copy link
Contributor

@sirpy sirpy commented Jul 10, 2023

Proposal to add GoodDollar (G$) as a gas token
Two proposals are created the first to add the oracle for the G$ celo price and the second is to add G$ as a gas token

Copy link
Member

@work-0xj4an work-0xj4an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirpy Please remove files with the number 0084 to be able to merge into CGP-0085 (CGP-0084 is already merged)

Copy link
Collaborator

@willkraft willkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not mean to approve - please see Juan's comment

@sirpy
Copy link
Contributor Author

sirpy commented Jul 23, 2023

@juanjgiraldoc @willkraft
i've modified the numbers to 85 and 88

@work-0xj4an
Copy link
Member

work-0xj4an commented Jul 24, 2023

@sirpy please rename files with 88 to 89. Proposal 88 already submitted and merged for Celo Korea DAO

@sirpy
Copy link
Contributor Author

sirpy commented Jul 24, 2023

@juanjgiraldoc done

@0xzoz 0xzoz dismissed willkraft’s stale review July 25, 2023 20:29

Changes completed

@0xzoz 0xzoz merged commit 0367bf5 into celo-org:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants