Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for NEN5104, update GEF properties #294

Merged
merged 3 commits into from
Mar 7, 2023
Merged

feat: support for NEN5104, update GEF properties #294

merged 3 commits into from
Mar 7, 2023

Conversation

RDWimmers
Copy link
Member

  • update properties
    • delivered_location
    • standardized_location
    • bro_id
    • QualityClass
  • add support for NEN5104
  • add merge figure that combines CPT and BHRgt
  • fix broxml resolvers

@RDWimmers RDWimmers requested a review from tversteeg March 6, 2023 14:23
@coveralls
Copy link

coveralls commented Mar 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4353779310

  • 132 of 154 (85.71%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 87.232%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pygef/broxml/parse_bore.py 3 4 75.0%
src/pygef/broxml/parse_cpt.py 4 5 80.0%
src/pygef/shim.py 9 10 90.0%
src/pygef/plotting.py 86 89 96.63%
src/pygef/broxml/resolvers.py 26 42 61.9%
Files with Coverage Reduction New Missed Lines %
src/pygef/broxml/resolvers.py 1 77.69%
src/pygef/shim.py 2 90.29%
Totals Coverage Status
Change from base Build 4323744572: -0.4%
Covered Lines: 936
Relevant Lines: 1073
💛 - Coveralls

tversteeg
tversteeg reviewed Mar 7, 2023
View reviewed changes
tests/xml/test_bore.py Outdated
if key != "niet gedefinieerd":
assert dist.sum() == 1.0
if key not in ["niet gedefinieerd", "unknown"]:
assert dist.sum() == 1.0, print(key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug print?

tversteeg
tversteeg reviewed Mar 7, 2023
View reviewed changes
tests/xml/test_bore.py Outdated Show resolved Hide resolved
@tversteeg tversteeg changed the title chore: update gef properties, add support for NEN5104 feat: support for NEN5104, update GEF properties Mar 7, 2023
@tversteeg tversteeg merged commit a1dde0c into master Mar 7, 2023
@tversteeg tversteeg deleted the 0.8.0-alpha.5 branch March 7, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tversteeg tversteeg tversteeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RDWimmers @coveralls @tversteeg