Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mario kart 8 lines bug #610

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

goeiecool9999
Copy link
Contributor

Fix #573
Before:
Screenshot_2024-03-10_23-15-32
After:
Screenshot_2024-03-10_23-13-32
Here you can see what the textures look like in RenderDoc
Screenshot_2024-03-10_23-13-12
Screenshot_2024-03-10_23-15-51

Oddly enough this only happens in OpenGL. Unless there's some rationale as to why this specific format needs to be changed that I'm unaware of it's probably best to remove this format change

@Crementif Crementif merged commit 7739e08 into cemu-project:master Mar 12, 2024
@Exzap
Copy link
Member

Exzap commented Mar 13, 2024

Unless there's some rationale as to why this specific format needs to be changed that I'm unaware of it's probably best to remove this format change

It's there to avoid color banding, but I don't know under which circumstances it would appear. Seems like this texture is used only for bloom or glow effects?

Anyway, I dug into this deeper on the Cemu side and it turns out there were bugs with the format overwrite feature on both OpenGL and Vulkan backends. On the latter it would mostly just be ignored and thats why there are no glitches. Commit with fixes will be pushed soon. I don't think we need to revert this PR unless we figure out what the removed rule does and if its even beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mario Kart 8] When enabling the graphics mod weird line glitches
3 participants