-
Notifications
You must be signed in to change notification settings - Fork 327
Set up Github Actions for pull request validation #1237
Conversation
What is the ultimate plan here? Migrate all projects from Travis to GitHub Actions? |
Interesting. I choose GHA because (most of) OpenTelemetry is using it and because I agree we should have a unified approach. Primary goal of this CL was to figure out how expensive it would be to migrate (not very), secondary goal was to unify the projects in terms of technology if we're going to maintain both for while. Given that OC is directly moving to OT, I thought unifying with OSS OT community would be better. It appears that within OT, (JS/Go APIs, Collector + Specification) use CircleCI and the spot check I did (swift, c++, java, .NET, erlang, Python, JavaScript) use GHA. I'm curious why there's such divergence between the repositories, do you know why to choose CircleCI over GHA? |
force a specific version of ubuntu Co-authored-by: Aaron Abbott <aaronabbott@google.com>
lfs: true | ||
- uses: actions/setup-go@v2 | ||
with: | ||
go-version: '^1.11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use something more recent. Maybe 1.14 or 1.15. I think GO11MODULE isn't needed after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is matching what we had in Travis-CI. I'm not going to bump to 1.14/1.15 unless we're officially dropping support for older Go version here, which we're not. This is just a migration.
Example of it working: https://github.com/jsuereth/opencensus-go/pull/1/checks