This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Fix LDAP sync deleting users from groups, closes #7142 #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When group membership is defined at group level, there were two issues with the syncWithLdap() function that is called periodically, specifically within listUserForGroup(): * groups were searched in the the user base DN * the group member attribute was not respected (a hardcoded value of "member" was used) This patch addresses both issues. The code that is used when a user first logs in makes use of the proper base DN and group member attribute. Because of this, users were added to the right groups on their first login, only to be later removed from them.
sc979
approved these changes
Oct 11, 2019
kduret
approved these changes
Oct 21, 2019
|
@sbraz I will check this today |
17 tasks
cgagnaire
added
area/ldap
pr/external
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When group membership is defined at group level, there were two issues with the
syncWithLdap()function that is called periodically, specifically withinlistUserForGroup():memberwas used)This patch addresses both issues. The first one is already fixed in 19.04.x (centreon/centreon@849b826) but the second one is still present in master. I'll let you guys patch it there too.
The code that is used when a user first logs in makes use of the proper base DN and group member attribute. Because this, users were added to the right groups on their first login, only to be later removed from them.