Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(BE): remove ACL notice on lvl3 calculation #8120

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Nov 13, 2019

Pull Request Template

Description

When user's ACL are calculated on a single lvl 3 element, a notice pop in the log

Fixes # (none)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Add to a user rights to a single lvl3 page. Check that the notice isn't displayed anymore in the php logs

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 force-pushed the MON-remove-acl-notice-on-lvl-3 branch from 7cfeab4 to 0785896 Compare November 25, 2019 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants