Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 4640 remove deprecated engine fields #8233

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Mon 4640 remove deprecated engine fields #8233

merged 4 commits into from
Feb 6, 2020

Conversation

lpinsivy
Copy link
Contributor

@lpinsivy lpinsivy commented Jan 3, 2020

Description

Remove useless engine configuration parameters :

  • check_result_path
  • use_check_result_path
  • max_check_result_file_age

From PR #7748

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@cgagnaire cgagnaire added pr/internal-rd PR made by the Centreon R&D Team status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Feb 6, 2020
@lpinsivy lpinsivy merged commit 2805a66 into master Feb 6, 2020
@lpinsivy lpinsivy deleted the MON-4640-remove-deprecated-engine-fields branch February 6, 2020 16:23
loiclau pushed a commit that referenced this pull request Feb 7, 2020
@lpinsivy @kduret
@sc979 @cgagnaire @loiclau
Mon 4640 remove deprecated engine fields (#8233)
0fed0bf 
* enh(engine): remove deprecated engine parameters
* enh: remove useless translations

Co-authored-by: Kevin Duret <duret.kevin@gmail.com>
Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com>
Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>
@cgagnaire cgagnaire mentioned this pull request Feb 11, 2020
Merged
17 tasks
sc979 added a commit that referenced this pull request Mar 18, 2020
@sc979 @loiclau
@cgagnaire @callapa @bdauria @lpinsivy @kduret
enh(core): replace centcore with gorgoned (#8414)
985c8ba 
* enh(core): generate centreon gorgone configuration file (#8160)

* enh(core): add gorgone configuration file generation

* fix: folder paths

* fix(core): naming of file and field type

* enh(core): update configuration file to take in account last modif

* fix(core): correct path to private key

* enh(core): add nodes module

* enh(core): store stats in cache dir

* enh(core): enable broker stats collection

* enh(poller) Update poller form to manage gorgone (#8184)

* enh(gorgone) Update config form to manage gorgone options  (#8197)

* enh(chore) replace centcore by gorgone (#8172)

* remove centcore perl script (#8209)

* fix(UI): do not display gorgone options on central's form (#8206)

* fix(UI): do not display gorgone options on central

* remove duplicated code (#8215)

* enh(admin): adapt broker stats page to new folder tree (#8216)

* enh(core): update script to manage gorgone configuration file (#8229)

* enh: exception management

* enh(update): generate gorgone conf file on update

* fix(translation): avoid empty gettext translation

* enh(core): Add a yaml configuration loader (#8270)

* MON-4737 enh(core): split gorgone configuration in different files (#8276)

* enh(core): adapt upgrade script to latest modifications (#8284)

* adapt update script

* enh: add more check brefore trying to create the conf files

* fix: correct path in the template

* enh(core): update gorgone configuration files (#8293)

* update configuration location

* enh(gorgone): Added API to communicate with the Gorgone server (#8294)

* enh(install): fix default keys pathes (#8302)

* fix db name configuration template

* replace remote data folder

* fix rest api test

* enh(UI): Add nowrap style to badge class - from aladdinchan (#8314)

* fix(ui): Add hash:8 suffix to font files to avoid asset conflicts and optimize Webpack config (#8305)

* Mon 4640 remove deprecated engine fields (#8233)

* fix(CI): add new tests to clapi diff

* fix(core): source install (#8396)

* enh(core): add gorgone user and copy ssh keys

* fix(api): fix options retrieval issue (#8412)

* fix(core): manage the gorgone configuration files (#8400)

* fix(core): duplicate SSH key on source upgrade (#8421)

Co-authored-by: loiclau <loic.lau@gmail.com>
Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Co-authored-by: Bruno d'Auria <bdauria@centreon.com>
Co-authored-by: Matthieu Kermagoret <mkermagoret@centreon.com>
Co-authored-by: Laurent Pinsivy <lpinsivy@centreon.com>
Co-authored-by: Kevin Duret <duret.kevin@gmail.com>
Co-authored-by: Laurent Calvet <laurent@callapa.com>
Co-authored-by: Kevin Duret <kduret@centreon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganoze ganoze ganoze approved these changes

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
area/configuration area/engine kind/enhancement pr/internal-rd PR made by the Centreon R&D Team status/needs-attention The PR is on-hold. The reasons are specified in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinsivy @ganoze @kduret @cgagnaire @sc979