Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(helper) fix path of the check command #8255

Merged
merged 3 commits into from
Jan 15, 2020

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Jan 14, 2020

Description

Macro problem, replace only $USERx$
Path problem, execute only plugins in /usr/lib64/nagios/plugins/

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Go to 'Configuration > Services > Templates'
Select a command in 'Check Command' field
Click on the :info: icon
Popup will always display "Error: Cannot Execute this command due to a path security problem."

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

loiclau and others added 2 commits January 14, 2020 11:15
Co-Authored-By: Kevin Duret <kduret@centreon.com>
Co-Authored-By: Kevin Duret <kduret@centreon.com>
@loiclau loiclau merged commit 656b0f0 into master Jan 15, 2020
@loiclau loiclau deleted the MON-4634-check-command-helper branch January 15, 2020 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants