Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(configuration): export "NULL" values correctly to remote server #8281

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

garnier-quentin
Copy link
Contributor

Pull Request Template

Description

In remote server, you get NULL values literraly (not in the database).

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Look the configuration on the remote server (a service or host object) before and after the patch. (you need to export the configuration).

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@cgagnaire cgagnaire added area/remote-server kind/fix pr/internal-ps PR made by the Centreon ProServices Team status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Feb 6, 2020
@cgagnaire cgagnaire changed the title fix null values remote export fix(configuration): export "NULL" values correctly to remote export Mar 4, 2020
@cgagnaire cgagnaire changed the title fix(configuration): export "NULL" values correctly to remote export fix(configuration): export "NULL" values correctly to remote server Mar 4, 2020
@sc979 sc979 added the status/more-info-needed Waiting for more information label Mar 9, 2020
@cgagnaire cgagnaire requested a review from kduret March 19, 2020 11:05
@cgagnaire cgagnaire removed status/more-info-needed Waiting for more information status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Mar 19, 2020
@cgagnaire cgagnaire merged commit afbdb85 into master Mar 19, 2020
@cgagnaire cgagnaire deleted the fix-remote-export-null-values branch March 19, 2020 13:18
cgagnaire pushed a commit that referenced this pull request Mar 19, 2020
…8281)

Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/remote-server kind/fix pr/internal-ps PR made by the Centreon ProServices Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants