Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Move annotations to separated yml files #8324

Merged
merged 13 commits into from
Feb 12, 2020
Merged

Conversation

vhr
Copy link
Contributor

@vhr vhr commented Feb 11, 2020

Pull Request Template

Description

The purpose of the PR is to move all annotations in src in YAML configuration files or other way of describing

Fixes MON-4795

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

the responses from APIv2 have to be the same as before

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

victorvassilev
victorvassilev previously approved these changes Feb 11, 2020
@cgagnaire cgagnaire added area/api kind/enhancement pr/internal-rd PR made by the Centreon R&D Team labels Feb 11, 2020
kduret
kduret previously approved these changes Feb 11, 2020
@vhr vhr merged commit 8f7e4af into master Feb 12, 2020
@vhr vhr deleted the MON-4795-convert-to-yaml-configs branch February 12, 2020 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api kind/enhancement pr/internal-rd PR made by the Centreon R&D Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants