Add option to set allowed origins #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
allowed_originsoption.This option allows setting an array of allowed origin patterns (array of strings) for WebSocket and SockJS endpoints to prevent CSRF attack. This is especially important when using connect proxy feature.
Originally cross-origin check was not too important due to JWT auth, now with connect proxy browser automatically passes cookies and origin check becomes necessary to secure an app. While it's already possible to validate origin on backend side looking at Origin header I think it's nice to have directly in Centrifugo.
If
allowed_originsoption not set at all then no origin check will be performed by Centrifugo.As soon as
allowed_originsdefined every connection request will be checked against each pattern in an array until a match.Centrifugo v3 may enforce same-origin strategy by default.