Improve delgation from class to default client. Drop support of Ruby 1.9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuned-up
commented
Apr 8, 2017
| describe Centrifuge do | ||
| context 'delegation' do | ||
| it 'class should delegate methods to default client' do | ||
| client_double = double('default_client') |
There was a problem hiding this comment.
Test creates a double, since some methods require args, and writing separate test for each delegation would create a lot of clutter.
|
Seems like gem is incompatible with ruby < 2 |
|
@tuned-up thanks! Asked @arrowcircle to review |
|
I think we can drop support of Ruby 1.9. Its EOL long time ago. |
|
@arrowcircle I agree - no need to support EOL software, users that need Ruby 1.9 can continue to use current version |
arrowcircle
changed the title
|
@arrowcircle 1.9.3 removed! |
|
@tuned-up Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to call all public methods from default client using
Centrifugeclass.Also, I found that there is no
timeout=method, so i remove a delegation.