Increase Faraday dependency's maximum version to 3.0.0 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraday's middleware has been deprecated since its version 2.0.0 release. Faraday 2.0.0 has built-in JSON middleware support which is the only middleware used by rubycent. rubycent still has the middleware dependency to support Faraday versions older than 2.0.0. https://github.com/lostisland/faraday/blob/main/UPGRADING.md#faraday-middleware-deprecation
Some client tests were failing with this error:
NoMethodError: undefined method `key?' for "{}":String (lib/cent/http.rb:42)
The failure is due to the difference between Faraday middleware's JSON `#parse_response?` implementation,
and Faraday's version 2.0.0 implementation of the now built-in `#parse_response?`.
The middleware parses the body if the body starts with a bracket.
https://github.com/lostisland/faraday_middleware/blob/3f6b113f6a7f71ef05c35a03514bbc08f7993dcf/lib/faraday_middleware/response/parse_json.rb#L35
While, Faraday parses the body if the response Content-Type header matches the configured value. (Default: /\bjson$/)
https://github.com/lostisland/faraday/blob/4816043101ea57f806d0946ed29f252e06d16909/lib/faraday/response/json.rb#L38
This commit fixes the error by adding a "Content-Type: application/json" header to the stubbed response.
|
@FZambia My pleasure. Rebased the branch with master. |
|
@hmnhf hello, part of v2.1.0 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday has deprecated its middleware gem since version 2.0.0 and introduced a new built-in JSON middleware. (Which is the only middleware used by rubycent.)
This pull request:
Updates Faraday's dependency version to allow using the latest version.
Requires the middleware gem only if Faraday's version is older than 2.0.0. (The middleware gem can be removed in the future after changing Faraday dependency's minimum version to 2.0.0.)
Fixes a failing test with Faraday versions 2.x. See the commit message of 450ed40 for a detailed explanation.