Make it compatible with Ruby 3 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponseError exception was created passing a hash as single argument. The exception class expect 2 keyword args. Before Ruby 3.0 it was working fine because Ruby automatically converted hash to keyword args. Startng from Ruby 3.0 a double splat operator is required otherwise the entire hash it treated as single positional argument.
|
@dck hello, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseErrorexception was created passing a hash as single argument. The exception class expects 2 keyword arguments. Before Ruby 3.0 it was working fine because Ruby automatically converted a hash to keyword args.Starting from Ruby 3.0 a double splat operator is required otherwise the entire hash it treated as single positional argument.
Before this fix both specs and production code failed with: