Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cephfs-shell #2211

Open
abh opened this issue May 25, 2024 · 7 comments · May be fixed by #2232
Open

Include cephfs-shell #2211

abh opened this issue May 25, 2024 · 7 comments · May be fixed by #2232

Comments

@abh
Copy link

abh commented May 25, 2024

It'd be helpful to have cephfs-shell for some debugging or diagnostic tasks included in the container image.

(see also rook/rook#10731 and #2072 from 2022 that was closed by the GitHub action)

Copy link

github-actions bot commented Jun 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@abh
Copy link
Author

abh commented Jun 10, 2024

Not stale

@github-actions github-actions bot removed the wontfix label Jun 10, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@abh
Copy link
Author

abh commented Jun 30, 2024

Not stale

@github-actions github-actions bot removed the wontfix label Jun 30, 2024
guits added a commit that referenced this issue Jul 1, 2024
This adds `cephfs-shell` package into the Ceph container image
as this tool can be useful when managing CephFS.

Fixes: #2211

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
@guits guits linked a pull request Jul 1, 2024 that will close this issue
@guits
Copy link
Collaborator

guits commented Jul 1, 2024

@abh this would be valid only for Debian-based images, right? As I realize we don't build the RPM by default, see [1][2]

[1] https://github.com/ceph/ceph/blob/main/ceph.spec.in#L1238
[2] https://download.ceph.com/rpm-reef/el9/noarch/

@abh
Copy link
Author

abh commented Jul 2, 2024

Hi @guits! Thank you for looking into this.

Rook is using centos 8 based images I think, so from that perspective it'd be better to have on the RPM-based systems too if possible; but the Debian image would be a start.

If it's added there I can take this back to the Rook project to see why they are using the CentOS based image if the Debian based one is "more supported". :-)

@guits
Copy link
Collaborator

guits commented Jul 2, 2024

The Debian-based image is not the most supported one; it's quite the opposite to be honest.
However, I've seen some recent efforts to make the project support Debian-based images again.
In any case, I think we should check why that RPM package isn't built first. Let me ping some people and try to get some details about that. I'll update this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants