-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get mem on cgroupsv2 #2119
get mem on cgroupsv2 #2119
Conversation
d329bfd
to
3c90753
Compare
I checked the failing test but got
Shall I run a bash linter or something? |
jenkins lint |
|
3c90753
to
3d05627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this patch but if you want to address the warning SC2071
L124 you can apply this small change:
diff --git a/src/daemon/common_functions.sh b/src/daemon/common_functions.sh
index 1b679c6c..9e99046f 100755
--- a/src/daemon/common_functions.sh
+++ b/src/daemon/common_functions.sh
@@ -121,7 +121,7 @@ function dev_part {
if [[ $(readlink -f "$option") == "$desired_partition" ]]; then
local optprefixlen
optprefixlen=$(prefix_length "$option" "$osd_device")
- if [[ $optprefixlen > $pfxlen ]]; then
+ if [[ $optprefixlen -gt $pfxlen ]]; then
link=$option
pfxlen=$optprefixlen
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KannarFr you need to add a sign off to your commit message
thanks!
0a2c438
to
6583c0f
Compare
@guits thanks for the hints. I applied all of them. I also sign off it. |
@KannarFr Could you squash the first 3 commits? I think you should have only 2 commits in this PR.
Thanks! |
@guits Damn I thought github will do it by itself. Done. |
6583c0f
to
7cb22fb
Compare
This commit adds cgroup2 support in get_available_ram() function defined in common_functions.sh Signed-off-by: Alexandre DUVAL - @KannarFr <kannarfr@gmail.com>
This addresses a `SC2071` warning. '>' operator is for string comparisons. `-gt` should be used here. See [1] [1] https://www.shellcheck.net/wiki/SC2071 Signed-off-by: Alexandre DUVAL - @KannarFr <kannarfr@gmail.com>
7cb22fb
to
9baede8
Compare
failure in |
@guits can you make a release with this patch? :) |
@KannarFr which release are you looking for? |
|
Description of your changes:
Fixes: #2118