Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reef release #2120

Closed
wants to merge 2 commits into from
Closed

add reef release #2120

wants to merge 2 commits into from

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented Jun 8, 2023

reef v18.1.0 is now available.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

reef v18.1.0 is now available.

Signed-off-by: Laura Flores <lflores@redhat.com>
@ljflores
Copy link
Contributor Author

ljflores commented Jun 8, 2023

Based on this commit: cd1c291

Signed-off-by: Laura Flores <lflores@redhat.com>
@dmick
Copy link
Member

dmick commented Jun 8, 2023

We need to positively verify that version of nfs-ganesha is appropriate/sanity-tested with reef, and wait for the checks to complete, but otherwise LGTM

@dmick dmick self-requested a review June 8, 2023 22:31
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments; just verify that nfs-ganesha version before committing.

@ljflores
Copy link
Contributor Author

ljflores commented Jun 8, 2023

I can also remove that part for now and we can deal with it later so the RC isn't blocked.

@dmick
Copy link
Member

dmick commented Jun 8, 2023

No, the question has to be answered and nfs-ganesha has to be included to be a valid container release. (I've also said many times that this ought to be a process that happens before we have to do the actual release, but it's fallen on deaf ears.)

@ljflores ljflores requested a review from dmick June 8, 2023 23:35
@ljflores
Copy link
Contributor Author

ljflores commented Jun 8, 2023

The x86_64 container build failed. Any suggestions?

@guits
Copy link
Collaborator

guits commented Jun 9, 2023

see #2109

@guits guits closed this Jun 9, 2023
@ljflores ljflores deleted the wip-reef branch June 9, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants