use wildcards for swid file addition #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to add new swid files downstream without needing to modify this file Signed-off-by: Andrew Schoen <aschoen@ibm.com>
|
Thanks. Did you test this? |
I have not yet. Would this be best to test manually as a patch downstream? |
|
fwiw # cat Dockerfile
FROM quay.ceph.io/ceph-ci/ceph:main
ADD *.test /var/lib/ceph/
# podman build -t docker.io/guits/ceph:swid .
STEP 1/2: FROM quay.ceph.io/ceph-ci/ceph:main
STEP 2/2: ADD *.test /var/lib/ceph/
--> Using cache e00984db2c25081a893e93dfca904cd6c1b6a26de37e329cb12650162f3c55ed
COMMIT docker.io/guits/ceph:cv-dmcrypt-optim
--> e00984db2c25
Successfully tagged docker.io/guits/ceph:swid
e00984db2c25081a893e93dfca904cd6c1b6a26de37e329cb12650162f3c55ed
# ls *.test
guits2.test guits.test
# podman run --rm -ti --entrypoint ls docker.io/guits/ceph:swid /var/lib/ceph/guits.test
/var/lib/ceph/guits.test
# podman run --rm -ti --entrypoint ls docker.io/guits/ceph:swid /var/lib/ceph/guits2.test
/var/lib/ceph/guits2.test
#not sure if there are details specific to downstream build context to verify in addition to that though. |
guits
approved these changes
Nov 9, 2023
|
Can we please get this merged? |
|
Reef change @ #2175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to add new swid files downstream without needing to modify this file