bump ganesha version in main containers to V5-stable

[dparmar18]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

[vshankar]

Is this valid? https://shaman.ceph.com/api/repos/nfs-ganesha/V5-stable/ return [].

Will this show up when we have stable builds?

[dparmar18]

oh so we only build 5.5 and 5.7 https://shaman.ceph.com/builds/nfs-ganesha/. we need to start building V5-stable first before merging this patch

[vshankar]

@ffilz did mention that v5-stable would be available.

[adk3798]

Once it actually is available on the ganesha side (it might already be, I haven't looked), you then have to update https://github.com/ceph/ceph-build/blob/main/nfs-ganesha/config/definitions/nfs-ganesha.yml#L41 to build 5-stable, wait for builds to start showing up in shaman, and then we can update ceph-container to point to it.

[guits]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

indeed, but we are not definitely getting rid of this maintenance, we will still have to maintain it for the major release of nfs-ganesha.
That is why, in my humble opinion, ceph@main should be tested with nfs-ganesha@next which is actually what we have always done before we decide to pin to a specific version because nfs-ganesha@next builds were broken for too long and wanted to unblock the testing, that was a temporarily workaround which was supposed to be reverted, see [1]

[1] b86898a

[dparmar18]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

indeed, but we are not definitely getting rid of this maintenance, we will still have to maintain it for the major release of nfs-ganesha. That is why, in my humble opinion, ceph@main should be tested with nfs-ganesha@next which is actually what we have always done before we decide to pin to a specific version because nfs-ganesha@next builds were broken for too long and wanted to unblock the testing, that was a temporarily workaround which was supposed to be reverted, see [1]

[1] b86898a

makes sense, https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557171 is now merged. So do you want me to replace V5-stable with next in this PR itself?

[ffilz]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

indeed, but we are not definitely getting rid of this maintenance, we will still have to maintain it for the major release of nfs-ganesha. That is why, in my humble opinion, ceph@main should be tested with nfs-ganesha@next which is actually what we have always done before we decide to pin to a specific version because nfs-ganesha@next builds were broken for too long and wanted to unblock the testing, that was a temporarily workaround which was supposed to be reverted, see [1]
[1] b86898a

makes sense, https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557171 is now merged. So do you want me to replace V5-stable with next in this PR itself?

Please don't build from next, there is no guarantee that next builds or runs. When we start Ganesha V6 development, next could easily become unstable.

V5-stable was specifically created for this purpose, I can move it forward to the current stable version of V5.x without your infrastructure having to change anything. Once we open V6 development, I have proposed to create V6-stable. At the start it might not have anything new in it.

[dparmar18]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

indeed, but we are not definitely getting rid of this maintenance, we will still have to maintain it for the major release of nfs-ganesha. That is why, in my humble opinion, ceph@main should be tested with nfs-ganesha@next which is actually what we have always done before we decide to pin to a specific version because nfs-ganesha@next builds were broken for too long and wanted to unblock the testing, that was a temporarily workaround which was supposed to be reverted, see [1]
[1] b86898a

makes sense, https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557171 is now merged. So do you want me to replace V5-stable with next in this PR itself?

Please don't build from next, there is no guarantee that next builds or runs. When we start Ganesha V6 development, next could easily become unstable.

V5-stable was specifically created for this purpose, I can move it forward to the current stable version of V5.x without your infrastructure having to change anything. Once we open V6 development, I have proposed to create V6-stable. At the start it might not have anything new in it.

since the ceph main is the latest branch that builds and runs fine which implies it is the latest stable(mostly), I think it should be paired with what is the latest stable version of nfs-ganesha, maybe a branch can be created like latest-stable that has the code as the name suggests, this can also help us not be consciously thinking about making changes to the infra like changing the branch names at every new release of nfs-ganesha. Does this make sense?

[vshankar]

Otherwise it will require conscious efforts to maintain the version which is a bit cumbersome.

indeed, but we are not definitely getting rid of this maintenance, we will still have to maintain it for the major release of nfs-ganesha. That is why, in my humble opinion, ceph@main should be tested with nfs-ganesha@next which is actually what we have always done before we decide to pin to a specific version because nfs-ganesha@next builds were broken for too long and wanted to unblock the testing, that was a temporarily workaround which was supposed to be reverted, see [1]
[1] b86898a

makes sense, https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557171 is now merged. So do you want me to replace V5-stable with next in this PR itself?

Please don't build from next, there is no guarantee that next builds or runs. When we start Ganesha V6 development, next could easily become unstable.
V5-stable was specifically created for this purpose, I can move it forward to the current stable version of V5.x without your infrastructure having to change anything. Once we open V6 development, I have proposed to create V6-stable. At the start it might not have anything new in it.

since the ceph main is the latest branch that builds and runs fine which implies it is the latest stable(mostly), I think it should be paired with what is the latest stable version of nfs-ganesha, maybe a branch can be created like latest-stable that has the code as the name suggests, this can also help us not be consciously thinking about making changes to the infra like changing the branch names at every new release of nfs-ganesha. Does this make sense?

Its good to know which ganesha stable version (5/6/..) is currently being used for testing (I understand its a naming thing).

I'm with @ffilz on this.

[vshankar]

fixed and updated. did a sample run for verification - https://pulpito.ceph.com/vshankar-2023-11-10_12:08:09-fs-wip-62584-pacific-testing-default-smithi/ (--filter client-limits)

[vshankar]

fixed and updated. did a sample run for verification - https://pulpito.ceph.com/vshankar-2023-11-10_12:08:09-fs-wip-62584-pacific-testing-default-smithi/ (--filter client-limits)

apologies - updated the incorrect PR :/

[vshankar]

@dparmar18 good to close I guess?

[dparmar18]

@dparmar18 good to close I guess?

yup