add support for multiple cosi drivers in k8s cluster #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thotz
force-pushed
the
mulitple-cosi-driver
branch
from
63509af
to
e834d70
Compare
BlaineEXE
reviewed
Feb 14, 2024
BlaineEXE
reviewed
Feb 14, 2024
thotz
force-pushed
the
mulitple-cosi-driver
branch
from
e834d70
to
bc1b7fc
Compare
BlaineEXE
suggested changes
Feb 26, 2024
thotz
force-pushed
the
mulitple-cosi-driver
branch
2 times, most recently
from
b7b1757
to
5aaf99b
Compare
BlaineEXE
reviewed
Mar 6, 2024
BlaineEXE
reviewed
Mar 6, 2024
cmd/ceph-cosi-driver/cmd.go
Outdated
Comment on lines
42
to
48
| if *driverPrefix == "" { | ||
| *driverPrefix = os.Getenv("POD_NAMESPACE") | ||
| } |
There was a problem hiding this comment.
I think it might be easier to maintain the driver and Rook integration with it longer-term if we get rid of POD_NAMESPACE checking entirely and make --driver-prefix a required flag.
I'd prefer to force the small number of current users to change their configuration now, rather than maintaining complex backwards compatibility code here and in Rook forever.
What do you think?
There was a problem hiding this comment.
Made requested changes
thotz
force-pushed
the
mulitple-cosi-driver
branch
from
5aaf99b
to
7f7d911
Compare
add support for multiple cosi drivers in k8s cluster by introducing driver-prefix option. Fixes: ceph#27 Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz
force-pushed
the
mulitple-cosi-driver
branch
from
7f7d911
to
d0df0dd
Compare
BlaineEXE
approved these changes
Mar 8, 2024
|
Looks good! Thanks :) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27