Skip to content

Commit

Permalink
e2e: fix logging as per new controller runtime
Browse files Browse the repository at this point in the history
fixing logging as per new controller runtime
errors

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
  • Loading branch information
Madhu-1 authored and iPraveenParihar committed May 21, 2024
1 parent cd17615 commit 89c4262
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions e2e/pvc.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,12 +297,12 @@ func deletePVCAndValidatePV(c kubernetes.Interface, pvc *v1.PersistentVolumeClai
int(time.Since(start).Seconds()))
pvc, err = c.CoreV1().PersistentVolumeClaims(nameSpace).Get(ctx, name, metav1.GetOptions{})
if err == nil {
framework.Logf("PVC %s (status: %s) has not been deleted yet, rechecking...", name, pvc.Status)
framework.Logf("PVC %s (status: %v) has not been deleted yet, rechecking...", name, pvc.Status)

return false, nil
}
if isRetryableAPIError(err) {
framework.Logf("failed to verify deletion of PVC %s (status: %s): %v", name, pvc.Status, err)
framework.Logf("failed to verify deletion of PVC %s (status: %v): %v", name, pvc.Status, err)

return false, nil
}
Expand Down Expand Up @@ -445,12 +445,12 @@ func waitForPVCToBeDeleted(c kubernetes.Interface, namespace, pvcName string, t
pvc.Status.String(),
int(time.Since(start).Seconds()))
if err == nil {
framework.Logf("PVC %s (status: %s) has not been deleted yet, rechecking...", pvcName, pvc.Status)
framework.Logf("PVC %s (status: %v) has not been deleted yet, rechecking...", pvcName, pvc.Status)

return false, nil
}
if isRetryableAPIError(err) {
framework.Logf("failed to verify deletion of PVC %s (status: %s): %v", pvcName, pvc.Status, err)
framework.Logf("failed to verify deletion of PVC %s (status: %v): %v", pvcName, pvc.Status, err)

return false, nil
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/rbd.go
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ var _ = Describe("RBD", func() {
pvc.Name,
metav1.DeleteOptions{})
if err != nil {
framework.Logf("failed to delete pvc: %w", err)
framework.Logf("failed to delete pvc: %s", err)
}

// Remove the claimRef to bind this PV to a new PVC.
Expand Down

0 comments on commit 89c4262

Please sign in to comment.