Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting pids.max failed with cgroups v2 #3085

Closed
Madhu-1 opened this issue May 4, 2022 · 1 comment · Fixed by #3091
Closed

setting pids.max failed with cgroups v2 #3085

Madhu-1 opened this issue May 4, 2022 · 1 comment · Fixed by #3091

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 4, 2022

I just had a similar error when setting up a K8s on a newer Flatcar server, because that one now uses
the cgroupv2 layout.
So,

ceph-csi/internal/util/pidlimit.go

Line 39 in 1bd6297

// $ cat /sys/fs/cgroup/pids + *.scope + /pids.max.
is not correct, since there is no directory /sys/fs/cgroup/pids any more.
It's now /sys/fs/cgroup + *.scope + /pids.max

Originally posted by @Cytrian in #3076 (comment)
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented May 4, 2022

new path is /sys/fs/cgroup/ + *.scope + /pids.max as per https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/using-cgroups-v2-to-control-distribution-of-cpu-time-for-applications_managing-monitoring-and-updating-the-kernel

Cytrian pushed a commit to Cytrian/ceph-csi that referenced this issue May 5, 2022
Support systems using the new cgroup v2 structure
2e01290 
With cgroup v2, the location of the pids.max file changed and so did the /proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all files are now in one directory.

fixes: ceph#3085
@Cytrian Cytrian mentioned this issue May 5, 2022
Merged
Cytrian pushed a commit to Cytrian/ceph-csi that referenced this issue May 5, 2022
util: support systems using the new cgroup v2 structure
e408dbf 
With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: ceph#3085

Signed-off-by: Marcus Röder <m.roeder@yieldlab.de>
Cytrian pushed a commit to Cytrian/ceph-csi that referenced this issue May 5, 2022
util: support systems using the new cgroup v2 structure
ce3e9e6 
With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: ceph#3085

Signed-off-by: Marcus Röder <m.roeder@yieldlab.de>
ceph-csi-bot pushed a commit to Cytrian/ceph-csi that referenced this issue May 7, 2022
@mergify
util: support systems using the new cgroup v2 structure
4663da3 
With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: ceph#3085

Signed-off-by: Marcus Röder <m.roeder@yieldlab.de>
@mergify mergify bot closed this as completed in #3091 May 7, 2022
mergify bot pushed a commit that referenced this issue May 7, 2022
@mergify
util: support systems using the new cgroup v2 structure
a95a621 
With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: #3085

Signed-off-by: Marcus Röder <m.roeder@yieldlab.de>
humblec pushed a commit to humblec/ceph-csi that referenced this issue May 9, 2022
@humblec
util: support systems using the new cgroup v2 structure
ebaf19f 
With cgroup v2, the location of the pids.max file changed and so did the
/proc/self/cgroup file

new /proc/self/cgroup file
`
0::/user.slice/user-500.slice/session-14.scope
`

old file:
`
11:pids:/user.slice/user-500.slice/session-2.scope
10:blkio:/user.slice
9:net_cls,net_prio:/
8:perf_event:/
...
`

There is no directory per subsystem (e.g. /sys/fs/cgroup/pids) any more, all
files are now in one directory.

fixes: ceph#3085

Signed-off-by: Marcus Röder <m.roeder@yieldlab.de>
@Madhu-1 Madhu-1 mentioned this issue Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: support systems using the new cgroup v2 structure Cytrian/ceph-csi
1 participant
@Madhu-1